impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "John Russell (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] Apply attribute to hide main data source topic in keydef tag.
Date Sat, 07 Jan 2017 00:38:18 GMT
John Russell has posted comments on this change.

Change subject: Apply attribute to hide main data source topic in keydef tag.
......................................................................


Patch Set 2: Code-Review+2 Verified+1

(2 comments)

I'll +2 this myself after verifying. The noise from warning messages in the doc builds makes
it trickier to verify all the other doc CRs.

http://gerrit.cloudera.org:8080/#/c/5592/1//COMMIT_MSG
Commit Message:

Line 7: Apply attribute to hide main data source topic in keydef tag.
> Long line.
Done


http://gerrit.cloudera.org:8080/#/c/5592/1/docs/impala.ditamap
File docs/impala.ditamap:

Line 846:       <keydef audience="Cloudera" href="topics/impala_data_sources.xml" keys="data_sources"/>
> The data sources feature has always been considered "not ready for prime ti
Done


-- 
To view, visit http://gerrit.cloudera.org:8080/5592
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5c7d3bf9a2a2c3fe73873fea95d025d838e987bb
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: John Russell <jrussell@cloudera.com>
Gerrit-Reviewer: Ambreen Kazi <ambreen.kazi@cloudera.com>
Gerrit-Reviewer: Anonymous Coward #250
Gerrit-Reviewer: Jim Apple <jbapple-impala@apache.org>
Gerrit-Reviewer: John Russell <jrussell@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message