impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Thomas Tauber-Marshall (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-4212: Add sink output expressions to explain output
Date Sat, 07 Jan 2017 00:08:18 GMT
Thomas Tauber-Marshall has posted comments on this change.

Change subject: IMPALA-4212: Add sink output expressions to explain output
......................................................................


Patch Set 1:

(4 comments)

http://gerrit.cloudera.org:8080/#/c/4783/1/fe/src/main/java/org/apache/impala/planner/DataSink.java
File fe/src/main/java/org/apache/impala/planner/DataSink.java:

Line 34: import java.util.ArrayList;
Looks like you don't actually use several of these - ArrayList, Splitter, WordUtils.


Line 77:     outputExprs_ = outputExprs;
single line


http://gerrit.cloudera.org:8080/#/c/4783/1/fe/src/main/java/org/apache/impala/planner/PlanRootSink.java
File fe/src/main/java/org/apache/impala/planner/PlanRootSink.java:

Line 34:     return String.format("PLAN-ROOT SINK [%s]\n", getOutputExprsString());
I guess you're ignoring prefix because its always going to be an empty string here? Maybe
note that.


Line 38:     return initThriftSink(TDataSinkType.PLAN_ROOT_SINK);
single line


-- 
To view, visit http://gerrit.cloudera.org:8080/4783
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I27c3a47d7ee28a9efb1405dd1a6ef9b7a83931f6
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Henry Robinson <henry@cloudera.com>
Gerrit-Reviewer: Marcel Kornacker <marcel@cloudera.com>
Gerrit-Reviewer: Thomas Tauber-Marshall <tmarshall@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message