impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Henry Robinson (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-3882: Simplify some query exec state locking
Date Fri, 06 Jan 2017 19:37:15 GMT
Henry Robinson has posted comments on this change.

Change subject: IMPALA-3882: Simplify some query exec state locking
......................................................................


Patch Set 6:

(1 comment)

Abandoned this for now: Sailesh's comment lead me down a rat hole that I don't have time to
address at the moment. We should pick this back up soon though, since the cascading locking
can cause problems.

http://gerrit.cloudera.org:8080/#/c/4935/6/be/src/service/impala-beeswax-server.cc
File be/src/service/impala-beeswax-server.cc:

Line 40: using namespace strings;
> This shouldn't be needed, we have 'using strings::Substitute' in names.h no
Done


-- 
To view, visit http://gerrit.cloudera.org:8080/4935
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I516357d2b5e9eb83e8209872cbe4c078c778a629
Gerrit-PatchSet: 6
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Henry Robinson <henry@cloudera.com>
Gerrit-Reviewer: Henry Robinson <henry@cloudera.com>
Gerrit-Reviewer: Sailesh Mukil <sailesh@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message