impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Tim Armstrong (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-4707: fix use-after-free in QueryExecMgr
Date Fri, 06 Jan 2017 02:16:03 GMT
Tim Armstrong has posted comments on this change.

Change subject: IMPALA-4707: fix use-after-free in QueryExecMgr
......................................................................


Patch Set 1:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/5615/1/be/src/runtime/query-exec-mgr.cc
File be/src/runtime/query-exec-mgr.cc:

Line 151:     qs = it->second;
> can you give this a new variable name to make it clear that it's not the sa
I ended up just using 'it' directly. We can also save a map looking by passing 'it' into erase
below.


Line 155:     // someone else might have increased the refcnt in the meantime
I won't touch this now but it doesn't seem like this should be possible.


-- 
To view, visit http://gerrit.cloudera.org:8080/5615
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I329ff758a0de148a3bdfedc245e56c3a63255535
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-Reviewer: Henry Robinson <henry@cloudera.com>
Gerrit-Reviewer: Jim Apple <jbapple-impala@apache.org>
Gerrit-Reviewer: Marcel Kornacker <marcel@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message