impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Tim Armstrong (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-4707: fix use-after-free in QueryExecMgr
Date Fri, 06 Jan 2017 02:15:57 GMT
Hello Jim Apple, Henry Robinson,

I'd like you to reexamine a change.  Please visit

    http://gerrit.cloudera.org:8080/5615

to look at the new patch set (#2).

Change subject: IMPALA-4707: fix use-after-free in QueryExecMgr
......................................................................

IMPALA-4707: fix use-after-free in QueryExecMgr

The bug is that the QueryState was referenced after the refcount is
decremented. The fix is to not do that.

Change-Id: I329ff758a0de148a3bdfedc245e56c3a63255535
---
M be/src/runtime/query-exec-mgr.cc
1 file changed, 12 insertions(+), 16 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/15/5615/2
-- 
To view, visit http://gerrit.cloudera.org:8080/5615
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I329ff758a0de148a3bdfedc245e56c3a63255535
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-Reviewer: Henry Robinson <henry@cloudera.com>
Gerrit-Reviewer: Jim Apple <jbapple-impala@apache.org>
Gerrit-Reviewer: Marcel Kornacker <marcel@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <tarmstrong@cloudera.com>

Mime
View raw message