impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Greg Rahn (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] Add thousands separator to cardinality in plan diagram
Date Thu, 05 Jan 2017 23:17:31 GMT
Greg Rahn has posted comments on this change.

Change subject: Add thousands separator to cardinality in plan diagram
......................................................................


Patch Set 5:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/5587/5/www/query_plan.tmpl
File www/query_plan.tmpl:

PS5, Line 107: .toLocaleString()
> Does .toLocaleString() mean that e.g. in Europe it would use space or other
See https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Number/toLocaleString


-- 
To view, visit http://gerrit.cloudera.org:8080/5587
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I23bfbd8d235c7f1ab7a22d640e557d8ae9a00947
Gerrit-PatchSet: 5
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Greg Rahn <grahn@cloudera.com>
Gerrit-Reviewer: Greg Rahn <grahn@cloudera.com>
Gerrit-Reviewer: Henry Robinson <henry@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: John Russell <jrussell@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message