impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Michael Brown (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-4355: random query generator: modify statement execution flow to support DML
Date Thu, 05 Jan 2017 19:38:17 GMT
Michael Brown has posted comments on this change.

Change subject: IMPALA-4355: random query generator: modify statement execution flow to support
DML
......................................................................


Patch Set 5:

(2 comments)

Hi Taras, I answered your questions without producing a new patch set.

http://gerrit.cloudera.org:8080/#/c/5387/5/tests/comparison/query.py
File tests/comparison/query.py:

Line 126:     self.execution = StatementExecutionMode.SELECT_STATEMENT
> Is this supposed to be self._execution?
It doesn't matter. The execution property object gets created at class-creation time.


Line 764:     self.execution = execution
> self._execution? Or this will call the @execution.setter?
It calls AbstractStatement.execution.setter.


-- 
To view, visit http://gerrit.cloudera.org:8080/5387
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia4c63a2223185d0e056cc5713796772e5d1b8414
Gerrit-PatchSet: 5
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Michael Brown <mikeb@cloudera.com>
Gerrit-Reviewer: David Knupp <dknupp@cloudera.com>
Gerrit-Reviewer: Michael Brown <mikeb@cloudera.com>
Gerrit-Reviewer: Taras Bobrovytsky <tbobrovytsky@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message