impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Impala Public Jenkins (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-3202: variable-length scratch file ranges
Date Thu, 05 Jan 2017 19:22:50 GMT
Impala Public Jenkins has submitted this change and it was merged.

Change subject: IMPALA-3202: variable-length scratch file ranges
......................................................................


IMPALA-3202: variable-length scratch file ranges

This uses a simple approach where scratch ranges are managed in
power-of-two size classes and we don't attempt to coalesce or
split the ranges to move them into different size classes. Thus
this does not optimally reuse space if a query spills a variety
of page sizes, but improving this may not be worth the added
complexity.

Testing:
Extended tmp-file-mgr-test to exercise the variable scratch range
support. We will get system test coverage once this is used by the
new buffer pool.

Change-Id: Ic0ad84493c2c93a5602c404a83c718f25ea25575
Reviewed-on: http://gerrit.cloudera.org:8080/5597
Reviewed-by: Tim Armstrong <tarmstrong@cloudera.com>
Tested-by: Impala Public Jenkins
---
M be/src/runtime/buffered-block-mgr.cc
M be/src/runtime/tmp-file-mgr-test.cc
M be/src/runtime/tmp-file-mgr.cc
M be/src/runtime/tmp-file-mgr.h
4 files changed, 95 insertions(+), 96 deletions(-)

Approvals:
  Impala Public Jenkins: Verified
  Tim Armstrong: Looks good to me, approved



-- 
To view, visit http://gerrit.cloudera.org:8080/5597
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ic0ad84493c2c93a5602c404a83c718f25ea25575
Gerrit-PatchSet: 7
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dhecht@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Tim Armstrong <tarmstrong@cloudera.com>

Mime
View raw message