impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alex Behm (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-3641: Fix catalogd RPC responses to DROP IF EXISTS.
Date Thu, 05 Jan 2017 00:22:15 GMT
Alex Behm has posted comments on this change.

Change subject: IMPALA-3641: Fix catalogd RPC responses to DROP IF EXISTS.
......................................................................


Patch Set 3:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/5556/3//COMMIT_MSG
Commit Message:

PS3, Line 9: a
> nit: remove
Done. I also added a snippet about the new strange behavior and why it's preferable over the
old bug.


http://gerrit.cloudera.org:8080/#/c/5556/3/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java
File fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java:

PS3, Line 2665: // Nothing was removed from the catalogd's cache.
              :         resp.result.setVersion(catalog_.getCatalogVersion());
              :         return;
> Summary from our offline discussion:
I filed IMPALA-4727 to track the new (less severe) consistency issue.


-- 
To view, visit http://gerrit.cloudera.org:8080/5556
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Icb1f31eb2ecf05b9b51ef4e12e6bb78f44d0cf84
Gerrit-PatchSet: 3
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Alex Behm <alex.behm@cloudera.com>
Gerrit-Reviewer: Alex Behm <alex.behm@cloudera.com>
Gerrit-Reviewer: Bharath Vissapragada <bharathv@cloudera.com>
Gerrit-Reviewer: Dimitris Tsirogiannis <dtsirogiannis@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message