impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Marcel Kornacker (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-4536: Decimal Parquet slots should be validated
Date Wed, 04 Jan 2017 23:52:17 GMT
Marcel Kornacker has posted comments on this change.

Change subject: IMPALA-4536: Decimal Parquet slots should be validated
......................................................................


Patch Set 1:

Thomas, Dan and I discussed this approach and concluded that it's better not to check for
overflows on reads, given the substantial performance impact and the fact that overflows won't
result in crashes, unlike for timestamps.

-- 
To view, visit http://gerrit.cloudera.org:8080/5525
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1ef3ab410843b33925d0387fcfd3bc4520e2fd81
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Thomas Tauber-Marshall <tmarshall@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dhecht@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv@cloudera.com>
Gerrit-Reviewer: Marcel Kornacker <marcel@cloudera.com>
Gerrit-Reviewer: Thomas Tauber-Marshall <tmarshall@cloudera.com>
Gerrit-HasComments: No

Mime
View raw message