impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alex Behm (Code Review)" <>
Subject [Impala-ASF-CR] IMPALA-3641: Fix catalogd RPC responses to DROP IF EXISTS.
Date Wed, 04 Jan 2017 23:43:54 GMT
Alex Behm has posted comments on this change.

Change subject: IMPALA-3641: Fix catalogd RPC responses to DROP IF EXISTS.

Patch Set 3:

(1 comment)
File fe/src/main/java/org/apache/impala/service/

PS3, Line 2665: // Nothing was removed from the catalogd's cache.
              :         resp.result.setVersion(catalog_.getCatalogVersion());
              :         return;
> If we have a role and two concurrent drop statements then the one will succ
Summary from our offline discussion:
- We agree that even today there is no guarantee of single-session consistency, i.e., a drop+add
may fail in the add for various reasons, e.g., due to another concurrent add.
- This patch fixes one issue, but introduces another issue as Dimitris described. We believe
the new behavior is not ideal, but better than the old behavior, explained as follows:
- The behavior before this patch is problematic because the drop of a completely unrelated
object can affect the consistency of a drop+add on another object.
- The behavior after this patch is that a drop+add may fail in the add if there is an ill-timed
concurrent drop of the same object.

To view, visit
To unsubscribe, visit

Gerrit-MessageType: comment
Gerrit-Change-Id: Icb1f31eb2ecf05b9b51ef4e12e6bb78f44d0cf84
Gerrit-PatchSet: 3
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Alex Behm <>
Gerrit-Reviewer: Alex Behm <>
Gerrit-Reviewer: Bharath Vissapragada <>
Gerrit-Reviewer: Dimitris Tsirogiannis <>
Gerrit-Reviewer: Tim Armstrong <>
Gerrit-HasComments: Yes

View raw message