impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Tim Armstrong (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-3202: variable-length scratch file ranges
Date Wed, 04 Jan 2017 23:14:27 GMT
Tim Armstrong has posted comments on this change.

Change subject: IMPALA-3202: variable-length scratch file ranges
......................................................................


Patch Set 4:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/5597/4/be/src/runtime/tmp-file-mgr.cc
File be/src/runtime/tmp-file-mgr.cc:

Line 351: void TmpFileMgr::FileGroup::AddFreeRange(WriteHandle* handle) {
> since it wouldn't be valid to use the WriteHandle once the range is added t
Done


-- 
To view, visit http://gerrit.cloudera.org:8080/5597
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic0ad84493c2c93a5602c404a83c718f25ea25575
Gerrit-PatchSet: 4
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dhecht@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message