impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jim Apple (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] DOCS-1757
Date Wed, 04 Jan 2017 20:26:48 GMT
Jim Apple has posted comments on this change.

Change subject: DOCS-1757
......................................................................


Patch Set 1:

(3 comments)

Hi Ambreen! Thank you for creating this patch.

http://gerrit.cloudera.org:8080/#/c/5594/1//COMMIT_MSG
Commit Message:

Line 7: DOCS-1757
Please add an IMPALA bug number, or omit if none. DOCS is an internal Cloudera-only JIRA project?


Line 8: 
Please add a description following the pattern you see when running git log: A one-line subject,
followed by two line breaks and more sentences if needed. Keep all lines not overflowing the
red line you see here, which I think is at 69 or 70 characters.


http://gerrit.cloudera.org:8080/#/c/5594/1/docs/topics/impala_authorization.xml
File docs/topics/impala_authorization.xml:

Line 952:             Availability (HA). This ensures that the URI will remain constant even
if the NameNode changes.
Does this error get made anywhere else in the docs?

You can fix it with the replace command, or sed.


-- 
To view, visit http://gerrit.cloudera.org:8080/5594
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ibf5f387fa07cf988a99b9ede4066bfd2b27afe16
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Ambreen Kazi <ambreen.kazi@cloudera.com>
Gerrit-Reviewer: Jim Apple <jbapple-impala@apache.org>
Gerrit-Reviewer: John Russell <jrussell@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message