impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Dimitris Tsirogiannis (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-3641: Fix catalogd RPC responses to DROP IF EXISTS.
Date Wed, 04 Jan 2017 19:21:56 GMT
Dimitris Tsirogiannis has posted comments on this change.

Change subject: IMPALA-3641: Fix catalogd RPC responses to DROP IF EXISTS.
......................................................................


Patch Set 3:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/5556/3/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java
File fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java:

PS3, Line 2665: // Nothing was removed from the catalogd's cache.
              :         resp.result.setVersion(catalog_.getCatalogVersion());
              :         return;
If we have a role and two concurrent drop statements then the one will successfully remove
the role and return the removed object while the other will simply return. But if the latter
then tries to recreate the role before the update from the statestore arrives, it will fail
because the local impalad catalog cache will think that the role is still there, no? My point
is that this change may be breaking single session consistency.


-- 
To view, visit http://gerrit.cloudera.org:8080/5556
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Icb1f31eb2ecf05b9b51ef4e12e6bb78f44d0cf84
Gerrit-PatchSet: 3
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Alex Behm <alex.behm@cloudera.com>
Gerrit-Reviewer: Alex Behm <alex.behm@cloudera.com>
Gerrit-Reviewer: Bharath Vissapragada <bharathv@cloudera.com>
Gerrit-Reviewer: Dimitris Tsirogiannis <dtsirogiannis@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message