impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Tim Armstrong (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-3202,IMPALA-2079: rework scratch file I/O
Date Wed, 04 Jan 2017 01:32:03 GMT
Tim Armstrong has posted comments on this change.

Change subject: IMPALA-3202,IMPALA-2079: rework scratch file I/O
......................................................................


Patch Set 24:

(6 comments)

http://gerrit.cloudera.org:8080/#/c/5141/24//COMMIT_MSG
Commit Message:

PS24, Line 27: disabled
> not implemented
Done


http://gerrit.cloudera.org:8080/#/c/5141/24/be/src/runtime/tmp-file-mgr-internal.h
File be/src/runtime/tmp-file-mgr-internal.h:

Line 41:   /// The physical file is created when the file is first written by DiskIoMgr.
> this sentence seems out of place (now that creation doesn't happen here), a
Done


Line 48:   /// Called to notify TmpFileMgr that an IO error was encountered for this file.
> Confusing given that TmpFileMgr is the one that calls this method (and so d
Done


PS24, Line 50: ReportIOError
> Maybe even rename this Blacklist() or similar, since that's the main side e
Done


PS24, Line 56: If this file does not
             :   /// reside on a known disk, e.g. it is a remote FS, disk IDs are chosen round-robin.
> this is more of a detail of the disk-io-mgr code that we call through to, s
Done


Line 58:   int DiskIdForWrite() const;
> it's a bit confusing that we call both this thing and 'disk_id_' a "disk id
Done


-- 
To view, visit http://gerrit.cloudera.org:8080/5141
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8c9c587df006d2f09d72dd636adafbd295fcdc17
Gerrit-PatchSet: 24
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dhecht@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message