impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "John Russell (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] Remove audienceb2Cloudera" from DITAVal, replace with audienceb2hidden".
Date Wed, 04 Jan 2017 00:06:50 GMT
John Russell has posted comments on this change.

Change subject: Remove audience="Cloudera" from DITAVal, replace with audience="hidden".
......................................................................


Patch Set 1:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/5591/1//COMMIT_MSG
Commit Message:

PS1, Line 7: Remove audience="Cloudera" from DITAVal
I tried to amend the commit message when squashing but must have done it wrong. I didn't actually
remove audience="Cloudera" yet because that would have caused a build error. I plan to get
rid of audience="Cloudera" in 3 stages each with its own gerrit review - add the capability
for audience="hidden", global search/replace of audience="Cloudera" -> audience="hidden",
and finally remove the possibility of having audience="Cloudera".


http://gerrit.cloudera.org:8080/#/c/5591/1/docs/impala_html.ditaval
File docs/impala_html.ditaval:

Line 21:      (obsolete or abandoned), or aspirational (maybe write new topic somewhere down
the road).
> long line.
I have an XML formatter tool that will apply some line length constraints, but because that
will cause such a large-scale diff across so many files I prefer to address line length globally
in a later gerrit review.


-- 
To view, visit http://gerrit.cloudera.org:8080/5591
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0771ccf912d8112194ad52a7fa76b092ea6cff72
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: John Russell <jrussell@cloudera.com>
Gerrit-Reviewer: Ambreen Kazi <ambreen.kazi@cloudera.com>
Gerrit-Reviewer: Anonymous Coward #250
Gerrit-Reviewer: Jim Apple <jbapple-impala@apache.org>
Gerrit-Reviewer: John Russell <jrussell@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message