impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "John Russell (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] Take out (stale) architecture diagram w/ Cloudera-specific terminology.
Date Tue, 03 Jan 2017 23:58:04 GMT
John Russell has posted comments on this change.

Change subject: Take out (stale) architecture diagram w/ Cloudera-specific terminology.
......................................................................


Patch Set 1:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/5596/1/docs/topics/impala_intro.xml
File docs/topics/impala_intro.xml:

Line 73:     <title>How Impala Works with <keyword keyref="hadoop_distro"/></title>
> Should this generally be made even more generic for users who don't use a d
Probably in the end it'll be a different name. I'll defer that to a global search/replace
after other cleanup is finished. I have a bunch of other private branches queued up with the
original set of keyref= substitution variables.


Line 82:       <p audience="Cloudera" conref="../shared/impala_common.xml#common/impala_overview_diagram"/>
> long line
The convention I adhere to is to not split within the same <tag attribute=...> block.
Makes searching simpler for idioms such as "tag containing attribute XYZ". There are some
verbose tags in DITA, usually centered around references with paths or URLs, where it's impractical
to let them split.


-- 
To view, visit http://gerrit.cloudera.org:8080/5596
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iab3786f113a5492f3aeac7480bfbfdb030cedf5b
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: John Russell <jrussell@cloudera.com>
Gerrit-Reviewer: Ambreen Kazi <ambreen.kazi@cloudera.com>
Gerrit-Reviewer: Anonymous Coward #250
Gerrit-Reviewer: Henry Robinson <henry@cloudera.com>
Gerrit-Reviewer: Jim Apple <jbapple-impala@apache.org>
Gerrit-Reviewer: John Russell <jrussell@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message