impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Tim Armstrong (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-4653: fix sticky config variable problem
Date Tue, 03 Jan 2017 20:15:41 GMT
Tim Armstrong has posted comments on this change.

Change subject: IMPALA-4653: fix sticky config variable problem
......................................................................


Patch Set 2:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/5545/2/bin/impala-config-branch.sh
File bin/impala-config-branch.sh:

Line 22
> an example would be helpful (e.g. in a comment) to be clear. I'm not sure w
Done


http://gerrit.cloudera.org:8080/#/c/5545/2/bin/impala-config.sh
File bin/impala-config.sh:

Line 75: IMPALA_TOOLCHAIN_BUILD_ID=308-96a4cc516e
> export this here rather than doing so separately on l179, to be consistent 
I ended up redoing this to be consistent everywhere - it was confusing because we use two
different . 

The next patchset just exports the variables when they're first declared i.e.

  export FOO=${FOO-default}
  
instead of

   : ${FOO=default}
   export FOO.


-- 
To view, visit http://gerrit.cloudera.org:8080/5545
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I930e2ca825142428d17a6981c77534ab0c8e3489
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dhecht@cloudera.com>
Gerrit-Reviewer: Matthew Jacobs <mj@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message