impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Tim Armstrong (Code Review)" <>
Subject [Impala-ASF-CR] IMPALA-4653: fix sticky config variable problem
Date Tue, 03 Jan 2017 20:15:38 GMT
Hello Dan Hecht,

I'd like you to reexamine a change.  Please visit

to look at the new patch set (#3).

Change subject: IMPALA-4653: fix sticky config variable problem

IMPALA-4653: fix sticky config variable problem

Previously we could get a developer's shell into a bad state where a
value of a config variable from a previous version
would override the value from the new version.

This change adds a new mechanism to override settings locally by adding
settings to This alternative approach is more
robust, because the config variables will be reset to the intended
values when is re-sourced. can also be used to override settings in a
version-controlled way, e.g. to support having different settings for
different branches.

I did not convert all variables to use this approach, since many people
and Jenkins jobs depend on setting these variables from the environment.
The remaining "sticky" variables are ones where default values should
not change frequently, e.g. source directory locations and build

Change-Id: I930e2ca825142428d17a6981c77534ab0c8e3489
M .gitignore
A bin/
M bin/
3 files changed, 137 insertions(+), 96 deletions(-)

  git pull ssh:// refs/changes/45/5545/3
To view, visit
To unsubscribe, visit

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I930e2ca825142428d17a6981c77534ab0c8e3489
Gerrit-PatchSet: 3
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Tim Armstrong <>
Gerrit-Reviewer: Dan Hecht <>
Gerrit-Reviewer: Matthew Jacobs <>
Gerrit-Reviewer: Tim Armstrong <>

View raw message