impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Henry Robinson (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] add thousands separator to cardinality tested manually by visually validating the cardinality numbers have thousands separators
Date Tue, 03 Jan 2017 20:06:27 GMT
Henry Robinson has posted comments on this change.

Change subject: add thousands separator to cardinality tested manually by visually validating
the cardinality numbers have thousands separators
......................................................................


Patch Set 2:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/5587/2//COMMIT_MSG
Commit Message:

PS2, Line 8: tested manually by visually validating the cardinality numbers have thousands
separators
add a blank line before this one, wrap to 80 chars, consider capitalizing sentences :)


-- 
To view, visit http://gerrit.cloudera.org:8080/5587
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I23bfbd8d235c7f1ab7a22d640e557d8ae9a00947
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Greg Rahn <grahn@cloudera.com>
Gerrit-Reviewer: Henry Robinson <henry@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message