impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Lars Volker (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-4689: Fix computation of last active time
Date Tue, 03 Jan 2017 19:30:25 GMT
Lars Volker has posted comments on this change.

Change subject: IMPALA-4689: Fix computation of last active time
......................................................................


Patch Set 1:

(2 comments)

Thanks for the review, please see PS2.

http://gerrit.cloudera.org:8080/#/c/5546/1/tests/common/impala_cluster.py
File tests/common/impala_cluster.py:

Line 122:     impalads.sort(key = lambda i: i.service.be_port)
> Maybe add a short comment explaining this.
Done


http://gerrit.cloudera.org:8080/#/c/5546/1/tests/custom_cluster/test_query_expiration.py
File tests/custom_cluster/test_query_expiration.py:

PS1, Line 41: _test
> Why add this?
It makes it possible to select just this test with "-k test_query_expiration". Otherwise test_query_expiration_no_default
also gets selected.


-- 
To view, visit http://gerrit.cloudera.org:8080/5546
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I283564c8d8e145d44d9493f4201555d3a1087edf
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Lars Volker <lv@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv@cloudera.com>
Gerrit-Reviewer: Thomas Tauber-Marshall <tmarshall@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message