impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "John Russell (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] Remove audienceb2Cloudera" from DITAVal, replace with audienceb2hidden".
Date Tue, 03 Jan 2017 19:18:56 GMT
John Russell has posted comments on this change.

Change subject: Remove audience="Cloudera" from DITAVal, replace with audience="hidden".
......................................................................


Patch Set 1:

(1 comment)

This is the sort of cleanup work that I propose being allowed to +2 myself.

http://gerrit.cloudera.org:8080/#/c/5591/1/docs/impala_html.ditaval
File docs/impala_html.ditaval:

PS1, Line 25: <prop att="audience" val="Cloudera" action="exclude"/>
> Hey the commit message said you (I) would remove audience="Cloudera".
Yeah, I edited the commit message to clarify but somehow the old message came through when
it was pushed. I'm leaving audience="Cloudera" in place so that everything continues to build
smoothly until after the big search/replace of audience="Cloudera" -> audience="hidden".
After that's complete I'll do a very small update to remove audience="Cloudera" from the 2
.ditaval files.


-- 
To view, visit http://gerrit.cloudera.org:8080/5591
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0771ccf912d8112194ad52a7fa76b092ea6cff72
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: John Russell <jrussell@cloudera.com>
Gerrit-Reviewer: John Russell <jrussell@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message