Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 7CE6F200BD8 for ; Wed, 7 Dec 2016 22:16:42 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id 7B82D160B0C; Wed, 7 Dec 2016 21:16:42 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id C1B97160AF9 for ; Wed, 7 Dec 2016 22:16:41 +0100 (CET) Received: (qmail 87276 invoked by uid 500); 7 Dec 2016 21:16:41 -0000 Mailing-List: contact reviews-help@impala.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list reviews@impala.incubator.apache.org Received: (qmail 87254 invoked by uid 99); 7 Dec 2016 21:16:40 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd4-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 07 Dec 2016 21:16:40 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id 55263C8A8B for ; Wed, 7 Dec 2016 21:16:40 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.362 X-Spam-Level: X-Spam-Status: No, score=0.362 tagged_above=-999 required=6.31 tests=[RDNS_DYNAMIC=0.363, SPF_PASS=-0.001] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024) with ESMTP id thMTMb2cZbzP for ; Wed, 7 Dec 2016 21:16:38 +0000 (UTC) Received: from ip-10-146-233-104.ec2.internal (ec2-75-101-130-251.compute-1.amazonaws.com [75.101.130.251]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTPS id 101065F238 for ; Wed, 7 Dec 2016 21:16:37 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by ip-10-146-233-104.ec2.internal (8.14.4/8.14.4) with ESMTP id uB7LFKUl008964; Wed, 7 Dec 2016 21:15:20 GMT Date: Wed, 7 Dec 2016 21:15:20 +0000 From: "Matthew Jacobs (Code Review)" To: impala-cr@cloudera.com, reviews@impala.incubator.apache.org Message-ID: Reply-To: mj@cloudera.com X-Gerrit-MessageType: newchange Subject: =?UTF-8?Q?=5BImpala-ASF-CR=5D_IMPALA-3788=3A_Fix_Kudu_ReadMode_flag_checking=0A?= X-Gerrit-Change-Id: I843842560844732505af53ea360a3a9ccbab04a9 X-Gerrit-ChangeURL: X-Gerrit-Commit: a4786dbea27b48ac22561898139b5635e6be1d0d MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/2.12.2 archived-at: Wed, 07 Dec 2016 21:16:42 -0000 Matthew Jacobs has uploaded a new change for review. http://gerrit.cloudera.org:8080/5402 Change subject: IMPALA-3788: Fix Kudu ReadMode flag checking ...................................................................... IMPALA-3788: Fix Kudu ReadMode flag checking Commit 0d4bdc1 to add flag --kudu_read_mode wasn't checking the value properly; so the behavior was reversed. This became apparent immediately in stress testing, though there isn't a good way to validate this in EE or unit tests. I added some logging which I used to verify the correct behavior manually in the minicluster. Change-Id: I843842560844732505af53ea360a3a9ccbab04a9 --- M be/src/exec/kudu-scanner.cc 1 file changed, 3 insertions(+), 2 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/02/5402/1 -- To view, visit http://gerrit.cloudera.org:8080/5402 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I843842560844732505af53ea360a3a9ccbab04a9 Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Matthew Jacobs