Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 27F11200BE7 for ; Tue, 20 Dec 2016 19:50:20 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id 267CC160B29; Tue, 20 Dec 2016 18:50:20 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 71A2F160B12 for ; Tue, 20 Dec 2016 19:50:19 +0100 (CET) Received: (qmail 7759 invoked by uid 500); 20 Dec 2016 18:50:18 -0000 Mailing-List: contact reviews-help@impala.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list reviews@impala.incubator.apache.org Received: (qmail 7748 invoked by uid 99); 20 Dec 2016 18:50:18 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 20 Dec 2016 18:50:18 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id 09EAA180A5A for ; Tue, 20 Dec 2016 18:50:18 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.363 X-Spam-Level: X-Spam-Status: No, score=0.363 tagged_above=-999 required=6.31 tests=[RDNS_DYNAMIC=0.363, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id Xd-uUkXyaMn8 for ; Tue, 20 Dec 2016 18:50:15 +0000 (UTC) Received: from ip-10-146-233-104.ec2.internal (ec2-75-101-130-251.compute-1.amazonaws.com [75.101.130.251]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTPS id 45AA65F5F8 for ; Tue, 20 Dec 2016 18:50:15 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by ip-10-146-233-104.ec2.internal (8.14.4/8.14.4) with ESMTP id uBKIn5CF022555; Tue, 20 Dec 2016 18:49:05 GMT Message-Id: <201612201849.uBKIn5CF022555@ip-10-146-233-104.ec2.internal> Date: Tue, 20 Dec 2016 18:49:05 +0000 From: "Tim Armstrong (Code Review)" To: impala-cr@cloudera.com, reviews@impala.incubator.apache.org CC: Dan Hecht Reply-To: tarmstrong@cloudera.com X-Gerrit-MessageType: comment Subject: =?UTF-8?Q?=5BImpala-ASF-CR=5D_IMPALA-3202=2CIMPALA-2079=3A_rework_scratch_file_I/O=0A?= X-Gerrit-Change-Id: I8c9c587df006d2f09d72dd636adafbd295fcdc17 X-Gerrit-ChangeURL: X-Gerrit-Commit: ea3aca6e9ad69827251ca54cea4df8e6a96aac23 In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/2.12.2 archived-at: Tue, 20 Dec 2016 18:50:20 -0000 Tim Armstrong has posted comments on this change. Change subject: IMPALA-3202,IMPALA-2079: rework scratch file I/O ...................................................................... Patch Set 16: (1 comment) http://gerrit.cloudera.org:8080/#/c/5141/16/be/src/runtime/buffered-block-mgr.cc File be/src/runtime/buffered-block-mgr.cc: Line 651: status = RepinInMemBlock(block); > That's not the case handled at line 624? The handling of that case is split between the two places. The first case above is when it gets the buffer without trading in 'release_block', this case is when it needs to trade in 'release_block'. We could probably restructure the code to collapse the cases but it doesn't seem worth it. -- To view, visit http://gerrit.cloudera.org:8080/5141 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8c9c587df006d2f09d72dd636adafbd295fcdc17 Gerrit-PatchSet: 16 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Tim Armstrong Gerrit-Reviewer: Dan Hecht Gerrit-Reviewer: Tim Armstrong Gerrit-HasComments: Yes