Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 60B37200BED for ; Sun, 18 Dec 2016 00:34:35 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id 5F5CF160B28; Sat, 17 Dec 2016 23:34:35 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id A989E160B16 for ; Sun, 18 Dec 2016 00:34:34 +0100 (CET) Received: (qmail 78520 invoked by uid 500); 17 Dec 2016 23:34:33 -0000 Mailing-List: contact reviews-help@impala.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list reviews@impala.incubator.apache.org Received: (qmail 78509 invoked by uid 99); 17 Dec 2016 23:34:33 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 17 Dec 2016 23:34:33 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id 39B97C1287 for ; Sat, 17 Dec 2016 23:34:33 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.363 X-Spam-Level: X-Spam-Status: No, score=0.363 tagged_above=-999 required=6.31 tests=[RDNS_DYNAMIC=0.363, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id y2kMQnJePNou for ; Sat, 17 Dec 2016 23:34:32 +0000 (UTC) Received: from ip-10-146-233-104.ec2.internal (ec2-75-101-130-251.compute-1.amazonaws.com [75.101.130.251]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTPS id 419005FCA2 for ; Sat, 17 Dec 2016 23:34:32 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by ip-10-146-233-104.ec2.internal (8.14.4/8.14.4) with ESMTP id uBHNYUFk001556; Sat, 17 Dec 2016 23:34:30 GMT Message-Id: <201612172334.uBHNYUFk001556@ip-10-146-233-104.ec2.internal> Date: Sat, 17 Dec 2016 23:34:30 +0000 From: "Jim Apple (Code Review)" To: Amos Bird , impala-cr@cloudera.com, reviews@impala.incubator.apache.org CC: Alex Behm , Jim Apple Reply-To: jbapple-impala@apache.org X-Gerrit-MessageType: comment Subject: =?UTF-8?Q?=5BImpala-ASF-CR=5D_IMPALA-4033=3A_Treat_string-partition_key_values_as_case_sensitive=2E=0A?= X-Gerrit-Change-Id: I6fbe67d99df8a50a16a18456fde85d03d622c7a1 X-Gerrit-ChangeURL: X-Gerrit-Commit: 2cd198611df21171bf1ab56f0b19ee49290ae03d In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/2.12.2 archived-at: Sat, 17 Dec 2016 23:34:35 -0000 Jim Apple has posted comments on this change. Change subject: IMPALA-4033: Treat string-partition key values as case sensitive. ...................................................................... Patch Set 2: Failing frontend tests: ``` org.apache.impala.common.AnalysisException: No matching partition(s) found. at org.apache.impala.analysis.PartitionSet.analyze(PartitionSet.java:97) at org.apache.impala.analysis.AlterTableSetStmt.analyze(AlterTableSetStmt.java:56) at org.apache.impala.analysis.AlterTableSetLocationStmt.analyze(AlterTableSetLocationStmt.java:73) at org.apache.impala.analysis.AnalysisContext.analyze(AnalysisContext.java:381) at org.apache.impala.common.FrontendTestBase.AnalyzesOk(FrontendTestBase.java:249) at org.apache.impala.common.FrontendTestBase.AnalyzesOk(FrontendTestBase.java:228) at org.apache.impala.analysis.AnalyzeDDLTest.TestAlterTableSet(AnalyzeDDLTest.java:426) at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) at java.lang.reflect.Method.invoke(Method.java:606) at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:50) at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12) at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:47) at org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17) at org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:27) at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:325) at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:78) at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:57) at org.junit.runners.ParentRunner$3.run(ParentRunner.java:290) at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:71) at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:288) at org.junit.runners.ParentRunner.access$000(ParentRunner.java:58) at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:268) at org.junit.runners.ParentRunner.run(ParentRunner.java:363) at org.apache.maven.surefire.junit4.JUnit4Provider.execute(JUnit4Provider.java:283) at org.apache.maven.surefire.junit4.JUnit4Provider.executeWithRerun(JUnit4Provider.java:173) at org.apache.maven.surefire.junit4.JUnit4Provider.executeTestSet(JUnit4Provider.java:153) at org.apache.maven.surefire.junit4.JUnit4Provider.invoke(JUnit4Provider.java:128) at org.apache.maven.surefire.booter.ForkedBooter.invokeProviderInSameClassLoader(ForkedBooter.java:203) at org.apache.maven.surefire.booter.ForkedBooter.runSuitesInProcess(ForkedBooter.java:155) at org.apache.maven.surefire.booter.ForkedBooter.main(ForkedBooter.java:103) ``` -- To view, visit http://gerrit.cloudera.org:8080/5535 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6fbe67d99df8a50a16a18456fde85d03d622c7a1 Gerrit-PatchSet: 2 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Amos Bird Gerrit-Reviewer: Alex Behm Gerrit-Reviewer: Amos Bird Gerrit-Reviewer: Jim Apple Gerrit-HasComments: No