Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 4C064200BEC for ; Thu, 15 Dec 2016 03:17:58 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id 4AA1F160B2E; Thu, 15 Dec 2016 02:17:58 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 9BEED160B19 for ; Thu, 15 Dec 2016 03:17:57 +0100 (CET) Received: (qmail 24276 invoked by uid 500); 15 Dec 2016 02:17:56 -0000 Mailing-List: contact reviews-help@impala.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list reviews@impala.incubator.apache.org Received: (qmail 24264 invoked by uid 99); 15 Dec 2016 02:17:56 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 15 Dec 2016 02:17:56 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id 365EF1A0845 for ; Thu, 15 Dec 2016 02:17:56 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.363 X-Spam-Level: X-Spam-Status: No, score=0.363 tagged_above=-999 required=6.31 tests=[RDNS_DYNAMIC=0.363, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id 5ymxPsEbg_RB for ; Thu, 15 Dec 2016 02:17:55 +0000 (UTC) Received: from ip-10-146-233-104.ec2.internal (ec2-75-101-130-251.compute-1.amazonaws.com [75.101.130.251]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTPS id AA4A05F2F1 for ; Thu, 15 Dec 2016 02:17:54 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by ip-10-146-233-104.ec2.internal (8.14.4/8.14.4) with ESMTP id uBF2HnbL026966; Thu, 15 Dec 2016 02:17:49 GMT Message-Id: <201612150217.uBF2HnbL026966@ip-10-146-233-104.ec2.internal> Date: Thu, 15 Dec 2016 02:17:49 +0000 From: "Michael Brown (Code Review)" To: Matthew Jacobs , impala-cr@cloudera.com, reviews@impala.incubator.apache.org CC: Dimitris Tsirogiannis Reply-To: mikeb@cloudera.com X-Gerrit-MessageType: comment Subject: =?UTF-8?Q?=5BImpala-ASF-CR=5D_IMPALA-4662=3A_Fix_NULL_literal_handling_in_Kudu_IN_list_predicates=0A?= X-Gerrit-Change-Id: Iaf2c10a326373ad80aef51a85cec64071daefa7b X-Gerrit-ChangeURL: X-Gerrit-Commit: 4a0bf4b9dfc73accdaf85e5436a8af7e1981c4e4 In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/2.12.2 archived-at: Thu, 15 Dec 2016 02:17:58 -0000 Michael Brown has posted comments on this change. Change subject: IMPALA-4662: Fix NULL literal handling in Kudu IN list predicates ...................................................................... Patch Set 2: Code-Review+1 Thanks for adding the additional test cases. My +1 means I'm satisfied that you addressed my comments, but obviously someone should take a look again at your FE changes. -- To view, visit http://gerrit.cloudera.org:8080/5505 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iaf2c10a326373ad80aef51a85cec64071daefa7b Gerrit-PatchSet: 2 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Matthew Jacobs Gerrit-Reviewer: Dimitris Tsirogiannis Gerrit-Reviewer: Matthew Jacobs Gerrit-Reviewer: Michael Brown Gerrit-HasComments: No