Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 9CA4D200BDB for ; Mon, 12 Dec 2016 18:55:07 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id 9B3A9160B22; Mon, 12 Dec 2016 17:55:07 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id E27D6160B1A for ; Mon, 12 Dec 2016 18:55:06 +0100 (CET) Received: (qmail 22025 invoked by uid 500); 12 Dec 2016 17:55:06 -0000 Mailing-List: contact reviews-help@impala.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list reviews@impala.incubator.apache.org Received: (qmail 22006 invoked by uid 99); 12 Dec 2016 17:55:05 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 12 Dec 2016 17:55:05 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id 796D2180371 for ; Mon, 12 Dec 2016 17:55:05 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.362 X-Spam-Level: X-Spam-Status: No, score=0.362 tagged_above=-999 required=6.31 tests=[RDNS_DYNAMIC=0.363, SPF_PASS=-0.001] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id ocIjhfitinww for ; Mon, 12 Dec 2016 17:55:04 +0000 (UTC) Received: from ip-10-146-233-104.ec2.internal (ec2-75-101-130-251.compute-1.amazonaws.com [75.101.130.251]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTPS id AFCC85F19B for ; Mon, 12 Dec 2016 17:55:04 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by ip-10-146-233-104.ec2.internal (8.14.4/8.14.4) with ESMTP id uBCHrbl0009024; Mon, 12 Dec 2016 17:53:37 GMT Message-Id: <201612121753.uBCHrbl0009024@ip-10-146-233-104.ec2.internal> Date: Mon, 12 Dec 2016 17:53:37 +0000 From: "David Knupp (Code Review)" To: Michael Brown , impala-cr@cloudera.com, reviews@impala.incubator.apache.org CC: Taras Bobrovytsky Reply-To: dknupp@cloudera.com X-Gerrit-MessageType: comment Subject: =?UTF-8?Q?=5BImpala-ASF-CR=5D_IMPALA-4355=3A_random_query_generator=3A_modify_statement_execution_flow_to_support_DML=0A?= X-Gerrit-Change-Id: Ia4c63a2223185d0e056cc5713796772e5d1b8414 X-Gerrit-ChangeURL: X-Gerrit-Commit: e0ca6944b328ce3bc47d07f680537866623bdd4d In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/2.12.2 archived-at: Mon, 12 Dec 2016 17:55:07 -0000 David Knupp has posted comments on this change. Change subject: IMPALA-4355: random query generator: modify statement execution flow to support DML ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/5387/1/tests/comparison/statement_generator.py File tests/comparison/statement_generator.py: PS1, Line 47: dml_table is a required Table object. The INSERT will be into this table. Maybe this is a nit, but there are three main docstring styles the I know of: Google, reST, and the older epydoc. AFAICT, we've never officially adopted any here. I wonder if we should? -- To view, visit http://gerrit.cloudera.org:8080/5387 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia4c63a2223185d0e056cc5713796772e5d1b8414 Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Michael Brown Gerrit-Reviewer: David Knupp Gerrit-Reviewer: Michael Brown Gerrit-Reviewer: Taras Bobrovytsky Gerrit-HasComments: Yes