Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 9BEED200BD5 for ; Thu, 8 Dec 2016 22:32:51 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id 9A7CA160B1F; Thu, 8 Dec 2016 21:32:51 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id E4E09160B0A for ; Thu, 8 Dec 2016 22:32:50 +0100 (CET) Received: (qmail 13694 invoked by uid 500); 8 Dec 2016 21:32:50 -0000 Mailing-List: contact reviews-help@impala.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list reviews@impala.incubator.apache.org Received: (qmail 13678 invoked by uid 99); 8 Dec 2016 21:32:49 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 08 Dec 2016 21:32:49 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id 74EECC7432 for ; Thu, 8 Dec 2016 21:32:49 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.363 X-Spam-Level: X-Spam-Status: No, score=0.363 tagged_above=-999 required=6.31 tests=[RDNS_DYNAMIC=0.363, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id fBsHu-sfegT4 for ; Thu, 8 Dec 2016 21:32:47 +0000 (UTC) Received: from ip-10-146-233-104.ec2.internal (ec2-75-101-130-251.compute-1.amazonaws.com [75.101.130.251]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTPS id BA03D5F571 for ; Thu, 8 Dec 2016 21:32:46 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by ip-10-146-233-104.ec2.internal (8.14.4/8.14.4) with ESMTP id uB8LWYY8013501; Thu, 8 Dec 2016 21:32:34 GMT Message-Id: <201612082132.uB8LWYY8013501@ip-10-146-233-104.ec2.internal> Date: Thu, 8 Dec 2016 21:32:33 +0000 From: "Henry Robinson (Code Review)" To: Dan Hecht , impala-cr@cloudera.com, reviews@impala.incubator.apache.org Reply-To: henry@cloudera.com X-Gerrit-MessageType: newpatchset Subject: =?UTF-8?Q?=5BImpala-ASF-CR=5D_IMPALA-4608=3A_Fix_fragment_completion_times_for_INSERTs=0A?= X-Gerrit-Change-Id: I3ce56f70d30c9e398b14b32520c815d87f81f893 X-Gerrit-ChangeURL: X-Gerrit-Commit: c227240b3e02b239ad5e2bcffc25bb71d39a596c In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/2.12.2 archived-at: Thu, 08 Dec 2016 21:32:51 -0000 Hello Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5418 to look at the new patch set (#3). Change subject: IMPALA-4608: Fix fragment completion times for INSERTs ...................................................................... IMPALA-4608: Fix fragment completion times for INSERTs Fix a bug where completion times weren't computed if the query was an INSERT, because the code presumed that instance 0 was always the coordinator fragment and skipped completion time computation. It may be that the special-casing can be removed entirely, but needs further investigation to make sure that wouldn't trigger any div-by-0 bugs. Change-Id: I3ce56f70d30c9e398b14b32520c815d87f81f893 --- M be/src/runtime/coordinator.cc 1 file changed, 6 insertions(+), 9 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/18/5418/3 -- To view, visit http://gerrit.cloudera.org:8080/5418 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I3ce56f70d30c9e398b14b32520c815d87f81f893 Gerrit-PatchSet: 3 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Henry Robinson Gerrit-Reviewer: Dan Hecht