Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 36630200BD8 for ; Wed, 7 Dec 2016 09:06:50 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id 3510D160B0A; Wed, 7 Dec 2016 08:06:50 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 7B74D160AFD for ; Wed, 7 Dec 2016 09:06:49 +0100 (CET) Received: (qmail 74835 invoked by uid 500); 7 Dec 2016 08:06:48 -0000 Mailing-List: contact reviews-help@impala.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list reviews@impala.incubator.apache.org Received: (qmail 74824 invoked by uid 99); 7 Dec 2016 08:06:48 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 07 Dec 2016 08:06:48 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id ECC571AB911 for ; Wed, 7 Dec 2016 08:06:47 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.362 X-Spam-Level: X-Spam-Status: No, score=0.362 tagged_above=-999 required=6.31 tests=[RDNS_DYNAMIC=0.363, SPF_PASS=-0.001] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id MSAP_Su9eIR6 for ; Wed, 7 Dec 2016 08:06:45 +0000 (UTC) Received: from ip-10-146-233-104.ec2.internal (ec2-75-101-130-251.compute-1.amazonaws.com [75.101.130.251]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTPS id 8E8B65F2EF for ; Wed, 7 Dec 2016 08:06:45 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by ip-10-146-233-104.ec2.internal (8.14.4/8.14.4) with ESMTP id uB7868AB022832; Wed, 7 Dec 2016 08:06:08 GMT Message-Id: <201612070806.uB7868AB022832@ip-10-146-233-104.ec2.internal> Date: Wed, 7 Dec 2016 08:06:08 +0000 From: "Michael Ho (Code Review)" To: Sailesh Mukil , impala-cr@cloudera.com, reviews@impala.incubator.apache.org Reply-To: kwho@cloudera.com X-Gerrit-MessageType: comment Subject: =?UTF-8?Q?=5BImpala-ASF-CR=5D_IMPALA-4594=3A_WriteSlot_and_CodegenWriteSlot_handle_escaped_NULL_slots_differently=0A?= X-Gerrit-Change-Id: I858e427ad7c2b2da8c2bb657be06b7443655781f X-Gerrit-ChangeURL: X-Gerrit-Commit: be803a3af609088e674553546357cb1e228c917c In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/2.12.2 archived-at: Wed, 07 Dec 2016 08:06:50 -0000 Michael Ho has posted comments on this change. Change subject: IMPALA-4594: WriteSlot and CodegenWriteSlot handle escaped NULL slots differently ...................................................................... Patch Set 3: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/5377 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I858e427ad7c2b2da8c2bb657be06b7443655781f Gerrit-PatchSet: 3 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Sailesh Mukil Gerrit-Reviewer: Michael Ho Gerrit-Reviewer: Sailesh Mukil Gerrit-HasComments: No