Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id B53A6200BE4 for ; Wed, 7 Dec 2016 01:12:37 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id B3C44160B29; Wed, 7 Dec 2016 00:12:37 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 0A5A5160B1B for ; Wed, 7 Dec 2016 01:12:36 +0100 (CET) Received: (qmail 5846 invoked by uid 500); 7 Dec 2016 00:12:36 -0000 Mailing-List: contact reviews-help@impala.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list reviews@impala.incubator.apache.org Received: (qmail 5827 invoked by uid 99); 7 Dec 2016 00:12:36 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd4-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 07 Dec 2016 00:12:36 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id A05D9C89B6 for ; Wed, 7 Dec 2016 00:12:35 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.363 X-Spam-Level: X-Spam-Status: No, score=0.363 tagged_above=-999 required=6.31 tests=[RDNS_DYNAMIC=0.363, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024) with ESMTP id 3hbFiCFXczLk for ; Wed, 7 Dec 2016 00:12:33 +0000 (UTC) Received: from ip-10-146-233-104.ec2.internal (ec2-75-101-130-251.compute-1.amazonaws.com [75.101.130.251]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTPS id EA2845FBBD for ; Wed, 7 Dec 2016 00:12:32 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by ip-10-146-233-104.ec2.internal (8.14.4/8.14.4) with ESMTP id uB70CVBk010594; Wed, 7 Dec 2016 00:12:31 GMT Message-Id: <201612070012.uB70CVBk010594@ip-10-146-233-104.ec2.internal> Date: Wed, 7 Dec 2016 00:12:31 +0000 From: "Alex Behm (Code Review)" To: impala-cr@cloudera.com, reviews@impala.incubator.apache.org CC: David Knupp , Dimitris Tsirogiannis Reply-To: alex.behm@cloudera.com X-Gerrit-MessageType: comment Subject: =?UTF-8?Q?=5BImpala-ASF-CR=5D_IMPALA-4592=3A_Improve_error_msg_for_non-deterministic_predicates=2E=0A?= X-Gerrit-Change-Id: I94765f62bde94f4faa7fc5c26d928099ca1496d1 X-Gerrit-ChangeURL: X-Gerrit-Commit: 38c973d308d13b9e8e41951748d7f87557bce3c3 In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/2.12.2 archived-at: Wed, 07 Dec 2016 00:12:37 -0000 Alex Behm has posted comments on this change. Change subject: IMPALA-4592: Improve error msg for non-deterministic predicates. ...................................................................... Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/5386/3/fe/src/main/java/org/apache/impala/planner/HdfsPartitionFilter.java File fe/src/main/java/org/apache/impala/planner/HdfsPartitionFilter.java: PS3, Line 129: This error is thrown to prevent " + : "returning wrong results because Impala cannot assign/evaluate " + : "this non-deterministic predicate correctly. > That statement doesn't seen to be always true, right? We do allow in some c it says "this non-deterministic" predicate? I'm not sure if mentioning partition pruning will be more or less confusing to the user for rand() > 100 -- To view, visit http://gerrit.cloudera.org:8080/5386 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I94765f62bde94f4faa7fc5c26d928099ca1496d1 Gerrit-PatchSet: 3 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Alex Behm Gerrit-Reviewer: Alex Behm Gerrit-Reviewer: David Knupp Gerrit-Reviewer: Dimitris Tsirogiannis Gerrit-HasComments: Yes