Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 34F6B200BD3 for ; Tue, 6 Dec 2016 22:47:44 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id 33940160B1B; Tue, 6 Dec 2016 21:47:44 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 7DA9B160B17 for ; Tue, 6 Dec 2016 22:47:43 +0100 (CET) Received: (qmail 16163 invoked by uid 500); 6 Dec 2016 21:47:42 -0000 Mailing-List: contact reviews-help@impala.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list reviews@impala.incubator.apache.org Received: (qmail 16143 invoked by uid 99); 6 Dec 2016 21:47:42 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 06 Dec 2016 21:47:42 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id 114F91AB7B2 for ; Tue, 6 Dec 2016 21:47:42 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.363 X-Spam-Level: X-Spam-Status: No, score=0.363 tagged_above=-999 required=6.31 tests=[RDNS_DYNAMIC=0.363, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id 5z6yj_qS6SmR for ; Tue, 6 Dec 2016 21:47:40 +0000 (UTC) Received: from ip-10-146-233-104.ec2.internal (ec2-75-101-130-251.compute-1.amazonaws.com [75.101.130.251]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTPS id 75C3D5FC1E for ; Tue, 6 Dec 2016 21:47:39 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by ip-10-146-233-104.ec2.internal (8.14.4/8.14.4) with ESMTP id uB6LlcKQ004133; Tue, 6 Dec 2016 21:47:38 GMT Message-Id: <201612062147.uB6LlcKQ004133@ip-10-146-233-104.ec2.internal> Date: Tue, 6 Dec 2016 21:47:38 +0000 From: "Tim Armstrong (Code Review)" To: Michael Ho , impala-cr@cloudera.com, reviews@impala.incubator.apache.org Reply-To: tarmstrong@cloudera.com X-Gerrit-MessageType: comment Subject: =?UTF-8?Q?=5BImpala-ASF-CR=5D_IMPALA-4595=3A_Ignore_discarded_functions_after_linking=0A?= X-Gerrit-Change-Id: Iaa056a0c888bfcc95b412e1bc1063bb607b58ab7 X-Gerrit-ChangeURL: X-Gerrit-Commit: 64a38cafe1c68054551b21d2e0a9546dbc31443e In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/2.12.2 archived-at: Tue, 06 Dec 2016 21:47:44 -0000 Tim Armstrong has posted comments on this change. Change subject: IMPALA-4595: Ignore discarded functions after linking ...................................................................... Patch Set 1: (1 comment) Code change looks good http://gerrit.cloudera.org:8080/#/c/5384/1/be/src/testutil/test-udfs.cc File be/src/testutil/test-udfs.cc: Line 152: // StringVal::null() doesn't inline its callee when compiled without optimization. Is there some way we can test this more directly? E.g. define a function with private linkage in this source file. -- To view, visit http://gerrit.cloudera.org:8080/5384 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iaa056a0c888bfcc95b412e1bc1063bb607b58ab7 Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Michael Ho Gerrit-Reviewer: Tim Armstrong Gerrit-HasComments: Yes