Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id A4327200BCF for ; Mon, 5 Dec 2016 08:09:02 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id A2C7C160B17; Mon, 5 Dec 2016 07:09:02 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id ECC5D160AF9 for ; Mon, 5 Dec 2016 08:09:01 +0100 (CET) Received: (qmail 72513 invoked by uid 500); 5 Dec 2016 07:09:00 -0000 Mailing-List: contact reviews-help@impala.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list reviews@impala.incubator.apache.org Received: (qmail 72502 invoked by uid 99); 5 Dec 2016 07:09:00 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd4-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 05 Dec 2016 07:09:00 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id EED6BC01DD for ; Mon, 5 Dec 2016 07:08:59 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.362 X-Spam-Level: X-Spam-Status: No, score=0.362 tagged_above=-999 required=6.31 tests=[RDNS_DYNAMIC=0.363, SPF_PASS=-0.001] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024) with ESMTP id knM3Zt3i2LCD for ; Mon, 5 Dec 2016 07:08:56 +0000 (UTC) Received: from ip-10-146-233-104.ec2.internal (ec2-75-101-130-251.compute-1.amazonaws.com [75.101.130.251]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTPS id 73D955FB36 for ; Mon, 5 Dec 2016 07:08:55 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by ip-10-146-233-104.ec2.internal (8.14.4/8.14.4) with ESMTP id uB578m0v014672; Mon, 5 Dec 2016 07:08:48 GMT Message-Id: <201612050708.uB578m0v014672@ip-10-146-233-104.ec2.internal> Date: Mon, 5 Dec 2016 07:08:48 +0000 From: "Alex Behm (Code Review)" To: impala-cr@cloudera.com, reviews@impala.incubator.apache.org CC: Tim Armstrong Reply-To: alex.behm@cloudera.com X-Gerrit-MessageType: comment Subject: =?UTF-8?Q?=5BImpala-ASF-CR=5D_IMPALA-4574=3A_Do_not_treat_UUID=28=29_like_a_constant_expr=2E=0A?= X-Gerrit-Change-Id: If2499f5f6ecdcb098623202c8e6dc2d02727194a X-Gerrit-ChangeURL: X-Gerrit-Commit: 5820c084f8b33b05149fc01844c4d91d129af3b2 In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/2.12.2 archived-at: Mon, 05 Dec 2016 07:09:02 -0000 Alex Behm has posted comments on this change. Change subject: IMPALA-4574: Do not treat UUID() like a constant expr. ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/5324/1/fe/src/main/java/org/apache/impala/analysis/FunctionCallExpr.java File fe/src/main/java/org/apache/impala/analysis/FunctionCallExpr.java: Line 246: if (fnName.equalsIgnoreCase("rand") || fnName.equalsIgnoreCase("random") > There is a regression in the 2.8.0 release though because I added more cach Ahh, thanks for clarifying, I did not realize that part was also a regression. Would be great if you could create a separate JIRA. Let's sync on the possible fixes. -- To view, visit http://gerrit.cloudera.org:8080/5324 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: If2499f5f6ecdcb098623202c8e6dc2d02727194a Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Alex Behm Gerrit-Reviewer: Alex Behm Gerrit-Reviewer: Tim Armstrong Gerrit-HasComments: Yes