Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 8D2CC200BD2 for ; Sat, 3 Dec 2016 07:46:10 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id 8BEB4160B0E; Sat, 3 Dec 2016 06:46:10 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id D4F4C160B09 for ; Sat, 3 Dec 2016 07:46:09 +0100 (CET) Received: (qmail 81573 invoked by uid 500); 3 Dec 2016 06:46:09 -0000 Mailing-List: contact reviews-help@impala.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list reviews@impala.incubator.apache.org Received: (qmail 81562 invoked by uid 99); 3 Dec 2016 06:46:08 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 03 Dec 2016 06:46:08 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id 511B8180533 for ; Sat, 3 Dec 2016 06:46:08 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.363 X-Spam-Level: X-Spam-Status: No, score=0.363 tagged_above=-999 required=6.31 tests=[RDNS_DYNAMIC=0.363, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id Js_BM_wuOvTN for ; Sat, 3 Dec 2016 06:46:06 +0000 (UTC) Received: from ip-10-146-233-104.ec2.internal (ec2-75-101-130-251.compute-1.amazonaws.com [75.101.130.251]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTPS id 5D70E5F3BA for ; Sat, 3 Dec 2016 06:46:05 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by ip-10-146-233-104.ec2.internal (8.14.4/8.14.4) with ESMTP id uB36k146027117; Sat, 3 Dec 2016 06:46:01 GMT Message-Id: <201612030646.uB36k146027117@ip-10-146-233-104.ec2.internal> Date: Sat, 3 Dec 2016 06:46:01 +0000 From: "Internal Jenkins (Code Review)" To: Alex Behm , impala-cr@cloudera.com, reviews@impala.incubator.apache.org X-Gerrit-MessageType: merged Subject: =?UTF-8?Q?=5BImpala-ASF-CR=5D_IMPALA-4577=3A_Adjust_maximum_size_of_row_batch_queue_with_MT_DOP=2E=0A?= X-Gerrit-Change-Id: Ic2aa260f9265ec21173fb703c41934964ece6485 X-Gerrit-ChangeURL: X-Gerrit-Commit: b237d1316eac6ccde4ce395b4c238997be3e2f8b In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/2.12.2 archived-at: Sat, 03 Dec 2016 06:46:10 -0000 Internal Jenkins has submitted this change and it was merged. Change subject: IMPALA-4577: Adjust maximum size of row batch queue with MT_DOP. ...................................................................... IMPALA-4577: Adjust maximum size of row batch queue with MT_DOP. When MT_DOP is set, non-Parquet scans are run with the old scan node with a fixed NUM_SCANNER_THREADS=1. This patch adjust the maximum size of the row batch queue based on MT_DOP for each such scan instance to avoid a significant increase in the memory consumption of such scans. The max queued batches per scan-node instance is at least 2 to always allow for some parallelism between the producer/consumer. Decreases the maximum allowed value for MT_DOP from 128 to 64. Change-Id: Ic2aa260f9265ec21173fb703c41934964ece6485 Reviewed-on: http://gerrit.cloudera.org:8080/5330 Reviewed-by: Alex Behm Tested-by: Internal Jenkins --- M be/src/exec/hdfs-scan-node.cc M be/src/exec/hdfs-scan-node.h M be/src/service/query-options.cc 3 files changed, 24 insertions(+), 11 deletions(-) Approvals: Internal Jenkins: Verified Alex Behm: Looks good to me, approved -- To view, visit http://gerrit.cloudera.org:8080/5330 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic2aa260f9265ec21173fb703c41934964ece6485 Gerrit-PatchSet: 5 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Alex Behm Gerrit-Reviewer: Alex Behm Gerrit-Reviewer: Internal Jenkins Gerrit-Reviewer: Marcel Kornacker Gerrit-Reviewer: Michael Ho Gerrit-Reviewer: Tim Armstrong