Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 03E15200BCE for ; Fri, 2 Dec 2016 23:31:52 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id 02994160B24; Fri, 2 Dec 2016 22:31:52 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 4BA1A160B08 for ; Fri, 2 Dec 2016 23:31:51 +0100 (CET) Received: (qmail 61890 invoked by uid 500); 2 Dec 2016 22:31:50 -0000 Mailing-List: contact reviews-help@impala.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list reviews@impala.incubator.apache.org Received: (qmail 61879 invoked by uid 99); 2 Dec 2016 22:31:50 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 02 Dec 2016 22:31:50 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id D35F41A0421 for ; Fri, 2 Dec 2016 22:31:49 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.362 X-Spam-Level: X-Spam-Status: No, score=0.362 tagged_above=-999 required=6.31 tests=[RDNS_DYNAMIC=0.363, SPF_PASS=-0.001] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id P_nDrkH2Z-SO for ; Fri, 2 Dec 2016 22:31:47 +0000 (UTC) Received: from ip-10-146-233-104.ec2.internal (ec2-75-101-130-251.compute-1.amazonaws.com [75.101.130.251]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTPS id 7046C5FD92 for ; Fri, 2 Dec 2016 22:31:47 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by ip-10-146-233-104.ec2.internal (8.14.4/8.14.4) with ESMTP id uB2MVlRY006504; Fri, 2 Dec 2016 22:31:47 GMT Message-Id: <201612022231.uB2MVlRY006504@ip-10-146-233-104.ec2.internal> Date: Fri, 2 Dec 2016 22:31:47 +0000 From: "Marcel Kornacker (Code Review)" To: Alex Behm , impala-cr@cloudera.com, reviews@impala.incubator.apache.org Reply-To: marcel@cloudera.com X-Gerrit-MessageType: comment Subject: =?UTF-8?Q?=5BImpala-ASF-CR=5D_IMPALA-4572=3A_Run_COMPUTE_STATS_on_Parquet_tables_with_MT_DOP=4=2E=0A?= X-Gerrit-Change-Id: I2be3c7c9f3004e9a759224a2e5756eb6e4efa359 X-Gerrit-ChangeURL: X-Gerrit-Commit: 2bf66c51d9e026e51cd593c7fd338f36557400cb In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/2.12.2 archived-at: Fri, 02 Dec 2016 22:31:52 -0000 Marcel Kornacker has posted comments on this change. Change subject: IMPALA-4572: Run COMPUTE STATS on Parquet tables with MT_DOP=4. ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/5315/1/fe/src/main/java/org/apache/impala/service/Frontend.java File fe/src/main/java/org/apache/impala/service/Frontend.java: Line 1052: if (!queryCtx.request.query_options.isSetMt_dop() && i think even if you leave 0 as a default in the .thrift file you can still check for it being set explicitly (which means you could get rid of the more complicated checking logic elsewhere in this patch). -- To view, visit http://gerrit.cloudera.org:8080/5315 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2be3c7c9f3004e9a759224a2e5756eb6e4efa359 Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Alex Behm Gerrit-Reviewer: Marcel Kornacker Gerrit-HasComments: Yes