Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 00070200BD4 for ; Fri, 2 Dec 2016 05:42:02 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id F2B63160B10; Fri, 2 Dec 2016 04:42:02 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 4754E160B0B for ; Fri, 2 Dec 2016 05:42:02 +0100 (CET) Received: (qmail 99652 invoked by uid 500); 2 Dec 2016 04:42:01 -0000 Mailing-List: contact reviews-help@impala.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list reviews@impala.incubator.apache.org Received: (qmail 99626 invoked by uid 99); 2 Dec 2016 04:42:00 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 02 Dec 2016 04:42:00 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id 82EB5C7C6D for ; Fri, 2 Dec 2016 04:42:00 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.362 X-Spam-Level: X-Spam-Status: No, score=0.362 tagged_above=-999 required=6.31 tests=[RDNS_DYNAMIC=0.363, SPF_PASS=-0.001] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id SV9lyA8J8Zru for ; Fri, 2 Dec 2016 04:41:58 +0000 (UTC) Received: from ip-10-146-233-104.ec2.internal (ec2-75-101-130-251.compute-1.amazonaws.com [75.101.130.251]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTPS id E101560E35 for ; Fri, 2 Dec 2016 04:41:57 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by ip-10-146-233-104.ec2.internal (8.14.4/8.14.4) with ESMTP id uB24etHd014762; Fri, 2 Dec 2016 04:40:55 GMT Message-Id: <201612020440.uB24etHd014762@ip-10-146-233-104.ec2.internal> Date: Fri, 2 Dec 2016 04:40:55 +0000 From: "Michael Brown (Code Review)" To: Matthew Jacobs , impala-cr@cloudera.com, reviews@impala.incubator.apache.org CC: Dimitris Tsirogiannis , David Knupp Reply-To: mikeb@cloudera.com X-Gerrit-MessageType: comment Subject: =?UTF-8?Q?=5BImpala-ASF-CR=5D_IMPALA-4567=3A_Fix_test_kudu_alter_table_exhaustive_failures=0A?= X-Gerrit-Change-Id: Ibca64d5567c24240606e454b052d130fcd0c3968 X-Gerrit-ChangeURL: X-Gerrit-Commit: 48983b389366eb7f792f5e309fa3eb77b70990f6 In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/2.12.2 archived-at: Fri, 02 Dec 2016 04:42:03 -0000 Michael Brown has posted comments on this change. Change subject: IMPALA-4567: Fix test_kudu_alter_table exhaustive failures ...................................................................... Patch Set 2: I see this is already submitted, but: > Do you know how I can only run 1 of the 2 (e.g. just codegen enabled) for this particular test fn? To be safe, I think the mark for serial is still a good idea, since the test truly needs to be serial. A quick method would simply be to inspect something in the vector and pytest.skip(), or separating out the Kudu DDL stuff separately into a separate class that only uses 1 dimension. There's no great, perfect solution available to us at this time though. -- To view, visit http://gerrit.cloudera.org:8080/5312 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibca64d5567c24240606e454b052d130fcd0c3968 Gerrit-PatchSet: 2 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Matthew Jacobs Gerrit-Reviewer: David Knupp Gerrit-Reviewer: Dimitris Tsirogiannis Gerrit-Reviewer: Internal Jenkins Gerrit-Reviewer: Matthew Jacobs Gerrit-Reviewer: Michael Brown Gerrit-HasComments: No