Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 5545D200BD4 for ; Fri, 2 Dec 2016 01:17:57 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id 53DD3160B10; Fri, 2 Dec 2016 00:17:57 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 9AC34160B0B for ; Fri, 2 Dec 2016 01:17:56 +0100 (CET) Received: (qmail 59811 invoked by uid 500); 2 Dec 2016 00:17:55 -0000 Mailing-List: contact reviews-help@impala.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list reviews@impala.incubator.apache.org Received: (qmail 59796 invoked by uid 99); 2 Dec 2016 00:17:54 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 02 Dec 2016 00:17:54 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id 4653F180652 for ; Fri, 2 Dec 2016 00:17:54 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.363 X-Spam-Level: X-Spam-Status: No, score=0.363 tagged_above=-999 required=6.31 tests=[RDNS_DYNAMIC=0.363, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id 0DELoC5uwhbS for ; Fri, 2 Dec 2016 00:17:52 +0000 (UTC) Received: from ip-10-146-233-104.ec2.internal (ec2-75-101-130-251.compute-1.amazonaws.com [75.101.130.251]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTPS id 04BFC5F306 for ; Fri, 2 Dec 2016 00:17:52 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by ip-10-146-233-104.ec2.internal (8.14.4/8.14.4) with ESMTP id uB20H7P7008860; Fri, 2 Dec 2016 00:17:07 GMT Message-Id: <201612020017.uB20H7P7008860@ip-10-146-233-104.ec2.internal> Date: Fri, 2 Dec 2016 00:17:07 +0000 From: "Tim Armstrong (Code Review)" To: Michael Ho , Alex Behm , impala-cr@cloudera.com, reviews@impala.incubator.apache.org Reply-To: tarmstrong@cloudera.com X-Gerrit-MessageType: newpatchset Subject: =?UTF-8?Q?=5BImpala-ASF-CR=5D_IMPALA-4525=3A_follow-on=3A_cleanup_error_handling=0A?= X-Gerrit-Change-Id: Ifb2e532381c3e6c7b2e3ef37c2d91fbebb2db2d0 X-Gerrit-ChangeURL: X-Gerrit-Commit: b4ff9513050b1050b999660cf5406f9f96129990 In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/2.12.2 archived-at: Fri, 02 Dec 2016 00:17:57 -0000 Hello Impala Public Jenkins, Michael Ho, Alex Behm, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5212 to look at the new patch set (#4). Change subject: IMPALA-4525: follow-on: cleanup error handling ...................................................................... IMPALA-4525: follow-on: cleanup error handling Testing: Ran exhaustive build. There is already some test coverage in test_exprs.py for errors returned during constant expr evaluation by the frontend. Change-Id: Ifb2e532381c3e6c7b2e3ef37c2d91fbebb2db2d0 --- M be/src/exprs/expr-context.cc M be/src/exprs/expr-context.h M be/src/service/fe-support.cc 3 files changed, 34 insertions(+), 40 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/12/5212/4 -- To view, visit http://gerrit.cloudera.org:8080/5212 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ifb2e532381c3e6c7b2e3ef37c2d91fbebb2db2d0 Gerrit-PatchSet: 4 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Tim Armstrong Gerrit-Reviewer: Alex Behm Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Michael Ho Gerrit-Reviewer: Michael Ho