Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 08D99200BD4 for ; Thu, 1 Dec 2016 22:42:01 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id 0774C160B0B; Thu, 1 Dec 2016 21:42:01 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 5C448160B05 for ; Thu, 1 Dec 2016 22:42:00 +0100 (CET) Received: (qmail 7891 invoked by uid 500); 1 Dec 2016 21:41:59 -0000 Mailing-List: contact reviews-help@impala.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list reviews@impala.incubator.apache.org Received: (qmail 7739 invoked by uid 99); 1 Dec 2016 21:41:59 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 01 Dec 2016 21:41:59 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id D44D21A9FA9 for ; Thu, 1 Dec 2016 21:41:58 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.363 X-Spam-Level: X-Spam-Status: No, score=0.363 tagged_above=-999 required=6.31 tests=[RDNS_DYNAMIC=0.363, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id UXCCUOttss3S for ; Thu, 1 Dec 2016 21:41:58 +0000 (UTC) Received: from ip-10-146-233-104.ec2.internal (ec2-75-101-130-251.compute-1.amazonaws.com [75.101.130.251]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTPS id 0F2335F306 for ; Thu, 1 Dec 2016 21:41:58 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by ip-10-146-233-104.ec2.internal (8.14.4/8.14.4) with ESMTP id uB1Lem2D002490; Thu, 1 Dec 2016 21:40:48 GMT Message-Id: <201612012140.uB1Lem2D002490@ip-10-146-233-104.ec2.internal> Date: Thu, 1 Dec 2016 21:40:48 +0000 From: "Dimitris Tsirogiannis (Code Review)" To: impala-cr@cloudera.com, reviews@impala.incubator.apache.org CC: Alex Behm , Todd Lipcon Reply-To: dtsirogiannis@cloudera.com X-Gerrit-MessageType: comment Subject: =?UTF-8?Q?=5BImpala-ASF-CR=5D_IMPALA-4527=3A_Columns_in_Kudu_tables_created_from_Impala_default_to_=22NULL=22=0A?= X-Gerrit-Change-Id: I950d9a9c64e3851e11a641573617790b340ece94 X-Gerrit-ChangeURL: X-Gerrit-Commit: 381a0eab611a98544620e42b0a280c4feb095099 In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/2.12.2 archived-at: Thu, 01 Dec 2016 21:42:01 -0000 Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-4527: Columns in Kudu tables created from Impala default to "NULL" ...................................................................... Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/5259/2/testdata/datasets/functional/functional_schema_template.sql File testdata/datasets/functional/functional_schema_template.sql: Line 552: CREATE TABLE {db_name}{db_suffix}.{table_name}_idx ( > Can we defer changes to this file until later? I'm worried having a stale d Done -- To view, visit http://gerrit.cloudera.org:8080/5259 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I950d9a9c64e3851e11a641573617790b340ece94 Gerrit-PatchSet: 2 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Dimitris Tsirogiannis Gerrit-Reviewer: Alex Behm Gerrit-Reviewer: Dimitris Tsirogiannis Gerrit-Reviewer: Todd Lipcon Gerrit-HasComments: Yes