Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 9EB1E200BD4 for ; Thu, 1 Dec 2016 19:39:58 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id 9D810160B0B; Thu, 1 Dec 2016 18:39:58 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id E48DA160B05 for ; Thu, 1 Dec 2016 19:39:57 +0100 (CET) Received: (qmail 90819 invoked by uid 500); 1 Dec 2016 18:39:57 -0000 Mailing-List: contact reviews-help@impala.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list reviews@impala.incubator.apache.org Received: (qmail 90797 invoked by uid 99); 1 Dec 2016 18:39:56 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 01 Dec 2016 18:39:56 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id 34600180554 for ; Thu, 1 Dec 2016 18:39:56 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.363 X-Spam-Level: X-Spam-Status: No, score=0.363 tagged_above=-999 required=6.31 tests=[RDNS_DYNAMIC=0.363, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id SJEqR7LlWEkU for ; Thu, 1 Dec 2016 18:39:54 +0000 (UTC) Received: from ip-10-146-233-104.ec2.internal (ec2-75-101-130-251.compute-1.amazonaws.com [75.101.130.251]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTPS id 0F6DF5F306 for ; Thu, 1 Dec 2016 18:39:54 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by ip-10-146-233-104.ec2.internal (8.14.4/8.14.4) with ESMTP id uB1Idis9027774; Thu, 1 Dec 2016 18:39:44 GMT Message-Id: <201612011839.uB1Idis9027774@ip-10-146-233-104.ec2.internal> Date: Thu, 1 Dec 2016 18:39:44 +0000 From: "Alex Behm (Code Review)" To: Tim Armstrong , impala-cr@cloudera.com, reviews@impala.incubator.apache.org Reply-To: alex.behm@cloudera.com X-Gerrit-MessageType: comment Subject: =?UTF-8?Q?=5BImpala-ASF-CR=5D_IMPALA-4525=3A_follow-on=3A_cleanup_error_handling=0A?= X-Gerrit-Change-Id: Ifb2e532381c3e6c7b2e3ef37c2d91fbebb2db2d0 X-Gerrit-ChangeURL: X-Gerrit-Commit: 85d7f816b94234c1c0e3faad14067bf8fe0042bd In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/2.12.2 archived-at: Thu, 01 Dec 2016 18:39:58 -0000 Alex Behm has posted comments on this change. Change subject: IMPALA-4525: follow-on: cleanup error handling ...................................................................... Patch Set 3: Code-Review+2 (1 comment) Thank you! http://gerrit.cloudera.org:8080/#/c/5212/3/be/src/service/fe-support.cc File be/src/service/fe-support.cc: Line 82: Status status = Status::OK(); goto is a real life saver here, much simpler -- To view, visit http://gerrit.cloudera.org:8080/5212 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ifb2e532381c3e6c7b2e3ef37c2d91fbebb2db2d0 Gerrit-PatchSet: 3 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Tim Armstrong Gerrit-Reviewer: Alex Behm Gerrit-Reviewer: Michael Ho Gerrit-HasComments: Yes