Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 8F8F0200BD4 for ; Thu, 1 Dec 2016 13:03:24 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id 8E36F160B0F; Thu, 1 Dec 2016 12:03:24 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id D3D5D160B0B for ; Thu, 1 Dec 2016 13:03:23 +0100 (CET) Received: (qmail 67917 invoked by uid 500); 1 Dec 2016 12:03:23 -0000 Mailing-List: contact reviews-help@impala.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list reviews@impala.incubator.apache.org Received: (qmail 67906 invoked by uid 99); 1 Dec 2016 12:03:22 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 01 Dec 2016 12:03:22 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id 630CA1A7A51 for ; Thu, 1 Dec 2016 12:03:22 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.363 X-Spam-Level: X-Spam-Status: No, score=0.363 tagged_above=-999 required=6.31 tests=[RDNS_DYNAMIC=0.363, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id gl32wrav-b_c for ; Thu, 1 Dec 2016 12:03:19 +0000 (UTC) Received: from ip-10-146-233-104.ec2.internal (ec2-75-101-130-251.compute-1.amazonaws.com [75.101.130.251]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTPS id 07F0C5F5F8 for ; Thu, 1 Dec 2016 12:03:18 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by ip-10-146-233-104.ec2.internal (8.14.4/8.14.4) with ESMTP id uB1C3HMr020239; Thu, 1 Dec 2016 12:03:17 GMT Message-Id: <201612011203.uB1C3HMr020239@ip-10-146-233-104.ec2.internal> Date: Thu, 1 Dec 2016 12:03:17 +0000 From: "Internal Jenkins (Code Review)" To: Michael Ho , impala-cr@cloudera.com, reviews@impala.incubator.apache.org X-Gerrit-MessageType: merged Subject: =?UTF-8?Q?=5BImpala-ASF-CR=5D_IMPALA-4557=3A_Fix_flakiness_with_FLAGS_stress_free_pool_alloc=0A?= X-Gerrit-Change-Id: I373035d209a0f3477650336ee6da458fa289dbe0 X-Gerrit-ChangeURL: X-Gerrit-Commit: b1edca2a5b6eb66fc5c316157f968b267ee36b48 In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/2.12.2 archived-at: Thu, 01 Dec 2016 12:03:24 -0000 Internal Jenkins has submitted this change and it was merged. Change subject: IMPALA-4557: Fix flakiness with FLAGS_stress_free_pool_alloc ...................................................................... IMPALA-4557: Fix flakiness with FLAGS_stress_free_pool_alloc FLAGS_stress_free_pool_alloc is a gflag for simulating malloc failure in debug builds. If set, FreePool::Allocate() and FreePool::Reallocate() will return NULL on every FLAGS_stress_free_pool_alloc allocations. The problem is that the counter for tracking number of allocations is updated racily by multiple threads, leading to non-determinism and flaky tests. This change fixes the problem by making the counter an AtomicInt32. Change-Id: I373035d209a0f3477650336ee6da458fa289dbe0 Reviewed-on: http://gerrit.cloudera.org:8080/5281 Reviewed-by: Jim Apple Reviewed-by: Dan Hecht Tested-by: Internal Jenkins --- M be/src/common/atomic.h M be/src/runtime/CMakeLists.txt A be/src/runtime/free-pool.cc M be/src/runtime/free-pool.h 4 files changed, 41 insertions(+), 6 deletions(-) Approvals: Jim Apple: Looks good to me, but someone else must approve Internal Jenkins: Verified Dan Hecht: Looks good to me, approved -- To view, visit http://gerrit.cloudera.org:8080/5281 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: merged Gerrit-Change-Id: I373035d209a0f3477650336ee6da458fa289dbe0 Gerrit-PatchSet: 4 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Michael Ho Gerrit-Reviewer: Dan Hecht Gerrit-Reviewer: Internal Jenkins Gerrit-Reviewer: Jim Apple Gerrit-Reviewer: Michael Ho Gerrit-Reviewer: Tim Armstrong