Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 5CE6D200BE2 for ; Thu, 1 Dec 2016 03:12:47 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id 5B7A2160B19; Thu, 1 Dec 2016 02:12:47 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id A2F37160B13 for ; Thu, 1 Dec 2016 03:12:46 +0100 (CET) Received: (qmail 50734 invoked by uid 500); 1 Dec 2016 02:12:45 -0000 Mailing-List: contact reviews-help@impala.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list reviews@impala.incubator.apache.org Received: (qmail 50715 invoked by uid 99); 1 Dec 2016 02:12:45 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 01 Dec 2016 02:12:45 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id 301CFC1AE1 for ; Thu, 1 Dec 2016 02:12:45 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.363 X-Spam-Level: X-Spam-Status: No, score=0.363 tagged_above=-999 required=6.31 tests=[RDNS_DYNAMIC=0.363, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id AJr8QUCHUb7Z for ; Thu, 1 Dec 2016 02:12:43 +0000 (UTC) Received: from ip-10-146-233-104.ec2.internal (ec2-75-101-130-251.compute-1.amazonaws.com [75.101.130.251]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTPS id 0B36A5FBAD for ; Thu, 1 Dec 2016 02:12:42 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by ip-10-146-233-104.ec2.internal (8.14.4/8.14.4) with ESMTP id uB12CfWA011421; Thu, 1 Dec 2016 02:12:41 GMT Message-Id: <201612010212.uB12CfWA011421@ip-10-146-233-104.ec2.internal> Date: Thu, 1 Dec 2016 02:12:41 +0000 From: "Marcel Kornacker (Code Review)" To: Alex Behm , impala-cr@cloudera.com, reviews@impala.incubator.apache.org Reply-To: marcel@cloudera.com X-Gerrit-MessageType: comment Subject: =?UTF-8?Q?=5BImpala-ASF-CR=5D_IMPALA-4303=3A_Do_not_reset=28=29_qualifier_of_union_operands=2E=0A?= X-Gerrit-Change-Id: I157bb0f08c4a94fd779487d7c23edd64a537a1f6 X-Gerrit-ChangeURL: X-Gerrit-Commit: 30122ff4236ab8f5f68c34ad28323406d67b3c25 In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/2.12.2 archived-at: Thu, 01 Dec 2016 02:12:47 -0000 Marcel Kornacker has posted comments on this change. Change subject: IMPALA-4303: Do not reset() qualifier of union operands. ...................................................................... Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/4963/1/fe/src/main/java/org/apache/impala/analysis/UnionStmt.java File fe/src/main/java/org/apache/impala/analysis/UnionStmt.java: Line 56: * Contains a query statement and the all/distinct qualifier adapt or remove that last sentence, which is redundant anyway. Line 61: // distinct propagation and unnesting that are needed after rewriting Subqueries. i don't understand the semantics of UnionStmt.reset() anymore. if we're trying to preserve the changes made during distinct propagation/unnesting, why are we resetting distinct-/allOperands_? can you describe the semantics of reset() succinctly? -- To view, visit http://gerrit.cloudera.org:8080/4963 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I157bb0f08c4a94fd779487d7c23edd64a537a1f6 Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Alex Behm Gerrit-Reviewer: Marcel Kornacker Gerrit-HasComments: Yes