impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "David Knupp (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-4684: Handle unexpected exceptions while checking for HBase nodes
Date Tue, 20 Dec 2016 00:07:34 GMT
David Knupp has uploaded a new change for review.

  http://gerrit.cloudera.org:8080/5547

Change subject: IMPALA-4684: Handle unexpected exceptions while checking for HBase nodes
......................................................................

IMPALA-4684: Handle unexpected exceptions while checking for HBase nodes

We weren't catching unexpected exceptions while checking HBase nodes,
and this created a condition whereby the Zookeeper client was closed
before it was stopped, which itself raises a new exception that masks
the original issue.

We should have catchall except clause that closes the Zookeeper client
if we know we can't proceed.

Tested by forcibly raising unexpected errors while checking for HBase
nodes.

Change-Id: I46a74d018f9169385a9f10a85718044c31a24dbc
---
M testdata/bin/check-hbase-nodes.py
1 file changed, 5 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/47/5547/1
-- 
To view, visit http://gerrit.cloudera.org:8080/5547
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I46a74d018f9169385a9f10a85718044c31a24dbc
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: David Knupp <dknupp@cloudera.com>

Mime
View raw message