impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Thomas Tauber-Marshall (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-4536: Decimal Parquet slots should be validated
Date Thu, 15 Dec 2016 20:57:31 GMT
Thomas Tauber-Marshall has uploaded a new change for review.

  http://gerrit.cloudera.org:8080/5525

Change subject: IMPALA-4536: Decimal Parquet slots should be validated
......................................................................

IMPALA-4536: Decimal Parquet slots should be validated

When reading decimal values in from parquet files we should
validate that the values fit within the maximum range for the
precision of the column.

Change-Id: I1ef3ab410843b33925d0387fcfd3bc4520e2fd81
---
M be/src/exec/parquet-column-readers.cc
M be/src/runtime/decimal-value.h
M common/thrift/generate_error_codes.py
M testdata/data/README
A testdata/data/out_of_range_decimal.parquet
A testdata/workloads/functional-query/queries/QueryTest/out-of-range-decimal-abort-on-error.test
A testdata/workloads/functional-query/queries/QueryTest/out-of-range-decimal-continue-on-error.test
M tests/query_test/test_scanners.py
8 files changed, 115 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/25/5525/1
-- 
To view, visit http://gerrit.cloudera.org:8080/5525
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I1ef3ab410843b33925d0387fcfd3bc4520e2fd81
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Thomas Tauber-Marshall <tmarshall@cloudera.com>

Mime
View raw message