impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sailesh Mukil (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] Clarify synchronization policy for 'done ' in KuduScanNode
Date Wed, 14 Dec 2016 00:24:32 GMT
Sailesh Mukil has uploaded a new change for review.

  http://gerrit.cloudera.org:8080/5494

Change subject: Clarify synchronization policy for 'done_' in KuduScanNode
......................................................................

Clarify synchronization policy for 'done_' in KuduScanNode

This patch adds a comment to calrify that it's safe to optimistically
read 'done_' in some places in KuduScanNode. This is to avoid some
confusion as the code synchronizes access to the variable in certain
places but not in others.

Also, did some miscellaneous cleanup in a couple of places.

Change-Id: I72c5f1fecf4bcf737d71a1fa13e59361604485f0
---
M be/src/exec/kudu-scan-node.cc
M be/src/exec/kudu-scan-node.h
2 files changed, 7 insertions(+), 10 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/94/5494/1
-- 
To view, visit http://gerrit.cloudera.org:8080/5494
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I72c5f1fecf4bcf737d71a1fa13e59361604485f0
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Sailesh Mukil <sailesh@cloudera.com>

Mime
View raw message