impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Bharath Vissapragada (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-3641: Fix catalogd RPC responses to DROP TABLE/DATABASE.
Date Thu, 22 Dec 2016 18:10:27 GMT
Bharath Vissapragada has posted comments on this change.

Change subject: IMPALA-3641: Fix catalogd RPC responses to DROP TABLE/DATABASE.
......................................................................


Patch Set 2: Code-Review+1

(2 comments)

http://gerrit.cloudera.org:8080/#/c/5556/2//COMMIT_MSG
Commit Message:

PS2, Line 7: DROP TABLE/DATABASE.
This might need an update since other responses were updated too.


http://gerrit.cloudera.org:8080/#/c/5556/2/fe/src/main/java/org/apache/impala/catalog/CatalogServiceCatalog.java
File fe/src/main/java/org/apache/impala/catalog/CatalogServiceCatalog.java:

PS2, Line 871: new table may
This seems to suggest that we can return null and still might add the new table. IIUC, that
is not possible here? If my understanding is correct, we might have to rephrase this?


-- 
To view, visit http://gerrit.cloudera.org:8080/5556
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Icb1f31eb2ecf05b9b51ef4e12e6bb78f44d0cf84
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Alex Behm <alex.behm@cloudera.com>
Gerrit-Reviewer: Alex Behm <alex.behm@cloudera.com>
Gerrit-Reviewer: Bharath Vissapragada <bharathv@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message