impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Tim Armstrong (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-4431: Add audit event log control mechanism to prevent disk overflow
Date Thu, 22 Dec 2016 15:47:51 GMT
Tim Armstrong has posted comments on this change.

Change subject: IMPALA-4431: Add audit event log control mechanism to prevent disk  overflow
......................................................................


Patch Set 11:

(2 comments)

Looks good - couple of minor comments

http://gerrit.cloudera.org:8080/#/c/4971/11/be/src/common/logging.cc
File be/src/common/logging.cc:

PS11, Line 181: max_log_files < 1
nit: rewrite as <= 0 to be consistent with other places


http://gerrit.cloudera.org:8080/#/c/4971/11/be/src/service/impala-server.h
File be/src/service/impala-server.h:

Line 272:   static std::string GetAuditEventLogFilePrefix();
Let's remove this function and simplify things by making AUDIT_EVENT_LOG_FILE_PREFIX a public
member of ImpalaServer.


-- 
To view, visit http://gerrit.cloudera.org:8080/4971
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8c3229cbdb6275f969c15258c9ccab6efeb24368
Gerrit-PatchSet: 11
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Donghui Xu <davyxdh@163.com>
Gerrit-Reviewer: Donghui Xu <davyxdh@163.com>
Gerrit-Reviewer: Lars Volker <lv@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message