impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alex Behm (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-3641: Fix catalogd RPC responses to DROP TABLE/DATABASE.
Date Wed, 21 Dec 2016 23:03:15 GMT
Alex Behm has posted comments on this change.

Change subject: IMPALA-3641: Fix catalogd RPC responses to DROP TABLE/DATABASE.
......................................................................


Patch Set 1:

(4 comments)

http://gerrit.cloudera.org:8080/#/c/5556/1//COMMIT_MSG
Commit Message:

Line 15: version (i.e., without incrementing the catalog version).
> Nice find :)
Thanks.


http://gerrit.cloudera.org:8080/#/c/5556/1/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java
File fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java:

Line 1070:     catalog_.removeDataSource(params.getData_source());
> Same.
I think this should work ok due to the check above, but I cleaned up the code to make it more
obvious.


Line 2080:         catalog_.renameTable(tableName.toThrift(), newTableName.toThrift()));
> Should we update this as well? renameTable() could potentially return null 
This case is a little tricky and somewhat broken. I removed the very confusing TableToTCatalogObject()
function and cleaned up the error handling here.


Line 2658:         role = new Role(createDropRoleParams.getRole_name(), Sets.<String>newHashSet());
> Shouldn't this be updated as well?
It should. Done.


-- 
To view, visit http://gerrit.cloudera.org:8080/5556
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Icb1f31eb2ecf05b9b51ef4e12e6bb78f44d0cf84
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Alex Behm <alex.behm@cloudera.com>
Gerrit-Reviewer: Alex Behm <alex.behm@cloudera.com>
Gerrit-Reviewer: Bharath Vissapragada <bharathv@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message