impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "David Knupp (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-4684: Wrap checking for HBase nodes ina try/finally block
Date Tue, 20 Dec 2016 17:53:30 GMT
David Knupp has posted comments on this change.

Change subject: IMPALA-4684: Wrap checking for HBase nodes ina  try/finally block
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/5547/1/testdata/bin/check-hbase-nodes.py
File testdata/bin/check-hbase-nodes.py:

Line 139:         errors = sum([check_znode(node, zk_client, timeout) for node in nodes])
> It might be cleaner to use a try/finally here so we stop it in the same pla
Done


-- 
To view, visit http://gerrit.cloudera.org:8080/5547
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I46a74d018f9169385a9f10a85718044c31a24dbc
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: David Knupp <dknupp@cloudera.com>
Gerrit-Reviewer: David Knupp <dknupp@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message