impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jim Apple (Code Review)" <>
Subject [Impala-ASF-CR] Set version of CDH dependencies to cdh5.11.0-SNAPSHOT.
Date Tue, 20 Dec 2016 05:43:38 GMT
Jim Apple has posted comments on this change.

Change subject: Set version of CDH dependencies to cdh5.11.0-SNAPSHOT.

Patch Set 3:

> The ninja part and the "all their valid combinations" was not clear
 > to me. It's great that we have additional validation, but I doubt
 > my change is going to break ninja. To me this looks more like a bug
 > in this Jenkins job, and I don't think it's necessary for me to fix
 > the GVO before merging this change which unblocks the rather
 > important integration job.

I don't necessarily think the external/public GVO job needs to be fixed first, either. When
I asked "Do you think this was spurious?" I was being genuine. It could be a ninja bug, it
could be a build script bug, it could be isolated to impala-lzo, it could be a Jenkins bug,
it could be a bug with this jenkins job config, and so on.

To view, visit
To unsubscribe, visit

Gerrit-MessageType: comment
Gerrit-Change-Id: I6b23fb1e4c041c377725a22e313d8bf747205e31
Gerrit-PatchSet: 3
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Alex Behm <>
Gerrit-Reviewer: Alex Behm <>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Jim Apple <>
Gerrit-Reviewer: Taras Bobrovytsky <>
Gerrit-Reviewer: Tim Armstrong <>
Gerrit-HasComments: No

View raw message