impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Internal Jenkins (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-4686: Fix schema output for INT96 columns in parquet-reader tool
Date Sat, 17 Dec 2016 00:32:46 GMT
Internal Jenkins has submitted this change and it was merged.

Change subject: IMPALA-4686: Fix schema output for INT96 columns in parquet-reader tool
......................................................................


IMPALA-4686: Fix schema output for INT96 columns in parquet-reader tool

Instead of manually mapping the types we can just look them up in the
thrift map.

Testing: I tested this change manually by compiling the tool and running
it on a parquet file that had a INT96 column. Here is the relevant
output:

Schema:
id  INT32
bool_col  BOOLEAN
tinyint_col  INT32
smallint_col  INT32
int_col  INT32
bigint_col  INT64
float_col  FLOAT
double_col  DOUBLE
date_string_col  BYTE_ARRAY
string_col  BYTE_ARRAY
timestamp_col  INT96
year  INT32
month  INT32

We only use this tool in one test currently, which calls it to make sure
that a parquet-file can be parsed by it. This implies that we have tests
that it compiles, but we don't make use of its output currently.

Change-Id: I5d92f5556554c71461a93fe0d598bb69f91cce51
Reviewed-on: http://gerrit.cloudera.org:8080/5536
Reviewed-by: Lars Volker <lv@cloudera.com>
Reviewed-by: Matthew Jacobs <mj@cloudera.com>
Tested-by: Internal Jenkins
---
M be/src/util/parquet-reader.cc
1 file changed, 3 insertions(+), 16 deletions(-)

Approvals:
  Lars Volker: Looks good to me, but someone else must approve
  Matthew Jacobs: Looks good to me, approved
  Internal Jenkins: Verified



-- 
To view, visit http://gerrit.cloudera.org:8080/5536
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I5d92f5556554c71461a93fe0d598bb69f91cce51
Gerrit-PatchSet: 3
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Lars Volker <lv@cloudera.com>
Gerrit-Reviewer: Internal Jenkins
Gerrit-Reviewer: Lars Volker <lv@cloudera.com>
Gerrit-Reviewer: Matthew Jacobs <mj@cloudera.com>

Mime
View raw message