impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Michael Brown (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-4355: random query generator: modify statement execution flow to support DML
Date Fri, 16 Dec 2016 23:33:08 GMT
Michael Brown has posted comments on this change.

Change subject: IMPALA-4355: random query generator: modify statement execution flow to support
DML
......................................................................


Patch Set 5:

(4 comments)

Please see patch set 5.

http://gerrit.cloudera.org:8080/#/c/5387/4/tests/comparison/discrepancy_searcher.py
File tests/comparison/discrepancy_searcher.py:

Line 198:               'https://issues.cloudera.org/browse/IMPALA-724')
> Not really relevant to this review, but it looks like this issue is resolve
It's WONTFIXed, so I've filed at IMPALA-4688 for auditing all workarounds.


http://gerrit.cloudera.org:8080/#/c/5387/4/tests/comparison/query.py
File tests/comparison/query.py:

PS4, Line 92: if self._execution is None:
> How about switching the if and else clauses around? I think it's simpler: i
Done


PS4, Line 93: ion('execu
> it's confusing where _execution is coming from. Did you mean to rename self
Done


http://gerrit.cloudera.org:8080/#/c/5387/4/tests/comparison/statement_generator.py
File tests/comparison/statement_generator.py:

PS4, Line 39: e):
> What's the point of setting this to None?
Done


-- 
To view, visit http://gerrit.cloudera.org:8080/5387
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia4c63a2223185d0e056cc5713796772e5d1b8414
Gerrit-PatchSet: 5
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Michael Brown <mikeb@cloudera.com>
Gerrit-Reviewer: David Knupp <dknupp@cloudera.com>
Gerrit-Reviewer: Michael Brown <mikeb@cloudera.com>
Gerrit-Reviewer: Taras Bobrovytsky <tbobrovytsky@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message